RFR: 8339983: [s390x] secondary_super_cache does not scale well: C1 and interpreter [v2]

Amit Kumar amitkumar at openjdk.org
Wed Nov 27 10:58:38 UTC 2024


On Mon, 25 Nov 2024 15:24:49 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion from Andrew
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3423:
> 
>> 3421:                                                        Register result) {
>> 3422:   assert_different_registers(r_sub_klass, r_super_klass, temp1, temp2, temp3, temp4, result, Z_R1_scratch, Z_R0_scratch);
>> 3423:   // Z_R0 will be only used in debug builds for slot value varification.
> 
> Typo. Type vErification, please.

We are not using Z_R0 anymore. So this is outdated :). The whole comment is gone now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22341#discussion_r1860449700


More information about the hotspot-dev mailing list