RFR: 8334305: Remove all code for nsk.share.Log verbose mode

[Ramkumar Sunderbabu]

On Mon, 30 Sep 2024 21:07:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Cleaning up nsk.share.Log code after the verbose mode was set always true.
>> 
>> Tested all the vmTestbase/ tests.
>
> test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 287:
> 
>> 285:         if (!verbose()) {
>> 286:             doPrint(message);
>> 287:         }
> 
> Is this method ever called? Is there a CR to remove it (and any references to it)?

These are deprecated methods and are still getting called. The calls need to be replaced with display. I will create a separate CR for this and address because the impact radius of such a change is bigger than this CR.

> test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 342:
> 
>> 340:      * Redirect log to the given <code>stream</code>
>> 341:      * Prints errors summary to current stream, cancel current stream
>> 342:      * and switches to new stream.
> 
> Does it really do all this? It looks to me like it just switches to the new stream. I'm not sure what is meant by "error summary" and cancelling.

marked for deprecation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1782010079
PR Review Comment: https://git.openjdk.org/jdk/pull/21267#discussion_r1782010577