RFR: 8293187: Store initialized Enum classes in AOTCache [v3]
Ioi Lam
iklam at openjdk.org
Tue Oct 1 06:14:54 UTC 2024
On Thu, 26 Sep 2024 21:02:07 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> @iklam are you planning to address this? Otherwise the patch looks good to me.
>
> Yes, I plan to to address this.
>
> I think the name `init_classes_reachable_from_archived_mirrors` is confusing, as it also initializes classes that may not be reachable from archived mirrors. I will try to rename this function and related data structures to make the meaning more obvious.
>
> I'd like to keep the logic the same, as I still need to do the initialization in 4 steps (boo1/boot2/platform/app) for classes listed under `_runtime_default_subgraph_info`. If I split up `_runtime_default_subgraph_info` into two separate parts the code will just become more verbose.
I renamed the function to `HeapShared::init_classes_for_special_subgraph()`. I also changed other `_default_subgraph` names to `special_subgraph`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20958#discussion_r1782167674
More information about the hotspot-dev
mailing list