RFR: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default

Y. Srinivas Ramakrishna ysr at openjdk.org
Tue Oct 1 18:59:49 UTC 2024


On Fri, 27 Sep 2024 20:12:59 GMT, Todd V. Jonker <duke at openjdk.org> wrote:

> `-UnlockExperimentalVMOptions` isn't necessarily the default: a distro may enable it in order to default-enable other features like JVMCI/Graal.
> 
> I'm not entirely satisfied by adding a `@require` that only applies to a subset of the checks in a test class.  In `VMOptionWarning`, the experimental flag only applies to the first of the three scenarios it checks.  But I suspect this is a general problem with `@require`, and I'd be happy to hear suggestions on how to avoid disabling too much.

The rationale for the change, and the change, both look good to me.

-------------

Marked as reviewed by ysr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21233#pullrequestreview-2338714452


More information about the hotspot-dev mailing list