RFR: 8293187: Store initialized Enum classes in AOTCache [v10]
Andrew Dinn
adinn at openjdk.org
Wed Oct 2 12:34:38 UTC 2024
On Wed, 2 Oct 2024 02:56:03 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Yes, it should be simpler, although perhaps at the cost of omitting some mirrors from the heap section. Anyway, the comment is helpful.
>
> @adinn I added the enforcement that for an aot-inited class, all of its super types's <clinit> must also be executed during assembly phase. I think this model is easier to understand. It also forces you to check if the side effects of the supertypes' <clinit>s can also be cached. Please re-review this change: [ba6f280](https://github.com/openjdk/jdk/pull/20958/commits/ba6f2805875beb02298d1615674147b65c98a039)
Yes, this change looks fine and this is a sensible restriction to avoid a grey area.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20958#discussion_r1784417656
More information about the hotspot-dev
mailing list