RFR: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default [v2]

[Todd V. Jonker]

On Tue, 1 Oct 2024 19:20:58 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Todd V. Jonker has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Refactor VMOptionWarning for better scoping of @require
>>  - Use simpler vm.opt.final approach
>
> test/jtreg-ext/requires/VMProps.java line 262:
> 
>> 260:         return "" + WB.getBooleanVMFlag("UnlockExperimentalVMOptions");
>> 261:     }
>> 262: 
> 
> I think an alternative here could be to just add UnlockExperimentalVMOptions to the list in vmOptFinalFlags and then use `!vm.opt.final.UnlockExperimentalVMOptions`. This is what we typically do when we want to filter on the final value of a specified flag.

Ah that's much easier.  I saw that there were several patterns in this file, and that approach sipped my radar.  Will update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21233#discussion_r1785090973