RFR: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default [v2]

Stefan Karlsson stefank at openjdk.org
Thu Oct 3 05:36:35 UTC 2024


On Wed, 2 Oct 2024 19:03:21 GMT, Todd V. Jonker <duke at openjdk.org> wrote:

>> `-UnlockExperimentalVMOptions` isn't necessarily the default: a distro may enable it in order to default-enable other features like JVMCI/Graal.
>> 
>> I'm not entirely satisfied by adding a `@require` that only applies to a subset of the checks in a test class.  In `VMOptionWarning`, the experimental flag only applies to the first of the three scenarios it checks.  But I suspect this is a general problem with `@require`, and I'd be happy to hear suggestions on how to avoid disabling too much.
>
> Todd V. Jonker has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Refactor VMOptionWarning for better scoping of @require
>  - Use simpler vm.opt.final approach

Looks good to me.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21233#pullrequestreview-2344682575


More information about the hotspot-dev mailing list