RFR: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class [v2]

Stefan Karlsson stefank at openjdk.org
Thu Oct 3 11:34:35 UTC 2024


On Thu, 3 Oct 2024 01:30:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Move NONCOPYABLE
>>  - Move VMStructs fields out of the CPU files
>>  - Add comment to the include of the platform specific class
>
> src/hotspot/share/runtime/osThread.hpp line 29:
> 
>> 27: 
>> 28: #include "utilities/macros.hpp"
>> 29: #include OS_HEADER(osThread)
> 
> Suggestion:
> 
> 
> // The actual class declaration is platform specific.
> #include OS_HEADER(osThread)

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21306#discussion_r1786066476


More information about the hotspot-dev mailing list