RFR: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Oct 3 13:57:38 UTC 2024


On Thu, 3 Oct 2024 12:50:52 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/os_cpu/bsd_aarch64/vmStructs_bsd_aarch64.hpp line 40:
>> 
>>> 38:   /******************************/                                                                                                   \
>>> 39:   nonstatic_field(OSThread,                      _thread_id,                                      OSThread::thread_id_t)             \
>>> 40:   nonstatic_field(OSThread,                      _unique_thread_id,                               uint64_t)
>> 
>> Does the SA actually use these?  I don't see any SA changes in this patch.  If it doesn't, we should remove it until there is someone that might add support for this.  We're not enhancing the SA at this point.
>
> I think the SA is using these. There are references to them in the various SA files.

Ok.  I see now why you don't also have to change SA.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21306#discussion_r1786270497


More information about the hotspot-dev mailing list