Integrated: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default

Todd V. Jonker duke at openjdk.org
Fri Oct 4 09:04:42 UTC 2024


On Fri, 27 Sep 2024 20:12:59 GMT, Todd V. Jonker <duke at openjdk.org> wrote:

> `-UnlockExperimentalVMOptions` isn't necessarily the default: a distro may enable it in order to default-enable other features like JVMCI/Graal.
> 
> I'm not entirely satisfied by adding a `@require` that only applies to a subset of the checks in a test class.  In `VMOptionWarning`, the experimental flag only applies to the first of the three scenarios it checks.  But I suspect this is a general problem with `@require`, and I'd be happy to hear suggestions on how to avoid disabling too much.

This pull request has now been integrated.

Changeset: 1bdd79e7
Author:    Todd V. Jonker <jonker at amazon.com>
URL:       https://git.openjdk.org/jdk/commit/1bdd79e7b2086197ab64161e89bbe8cc180f07ed
Stats:     64 lines in 3 files changed: 44 ins; 6 del; 14 mod

8341261: Tests assume UnlockExperimentalVMOptions is disabled by default

Reviewed-by: stefank, mli, ysr

-------------

PR: https://git.openjdk.org/jdk/pull/21233


More information about the hotspot-dev mailing list