RFR: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code

Fei Yang fyang at openjdk.org
Mon Oct 7 03:19:34 UTC 2024


On Sat, 5 Oct 2024 10:03:30 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The command "java -XX:+UnlockDiagnosticVMOptions -XX:+PrintInterpreter" can be used to print a disassembly of the HotSpot interpreter.
> In [JDK-8204267](https://bugs.openjdk.org/browse/JDK-8204267), the interpreter generate comments to link the instructions back to the C++ source code that generates them, but the releated PR only support x86 backend, I think it's doable on RISC-V either.
> 
> Additonal testing:
> 
> - [x] riscv native build with slowdebug and fastdebug
> - [x] jtreg tier1 test with release build

Seems fine to me. One minor question though.

src/hotspot/cpu/riscv/methodHandles_riscv.cpp line 4:

> 2:  * Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2014, Red Hat Inc. All rights reserved.
> 4:  * Copyright (c) 2020, 2024, Huawei Technologies Co., Ltd. All rights reserved.

Should we update other vendor's copyright year?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21370#pullrequestreview-2350763545
PR Review Comment: https://git.openjdk.org/jdk/pull/21370#discussion_r1789418876


More information about the hotspot-dev mailing list