RFR: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code

Johan Sjölen jsjolen at openjdk.org
Tue Oct 8 12:35:59 UTC 2024


On Tue, 8 Oct 2024 06:17:56 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The command "java -XX:+UnlockDiagnosticVMOptions -XX:+PrintInterpreter" can be used to print a disassembly of the HotSpot interpreter.
> In [JDK-8204267](https://bugs.openjdk.org/browse/JDK-8204267), the interpreter generate comments to link the instructions back to the C++ source code that generates them, but the releated PR only support x86 backend, I think it's doable on aarch64 either.
> 
> Additonal testing:
> 
> - [x] aarch64 native build with slowdebug and fastdebug
> - [x] jtreg tests(include tier1/tier2/tier3 etc.) with release build

LGTM, thanks. I'm OK with the added comments to the set_vtos_enry_points function.

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21400#pullrequestreview-2354354012


More information about the hotspot-dev mailing list