RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing

[Matias Saavedra Silva]

On Fri, 4 Oct 2024 02:15:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`. 
>> 
>> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.
>
> src/hotspot/share/cds/metaspaceShared.cpp line 764:
> 
>> 762: 
>> 763: void MetaspaceShared::make_dummy_calls(TRAPS) {
>> 764:   // Exercise the manifest processing code
> 
> Nit: can we think of a better name rather than "dummy"?

Would `exercise_runtime_cds_code()` be better?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21329#discussion_r1792122561