RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Tue Oct 8 17:18:46 UTC 2024
> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`.
>
> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.
Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Removed test from problem list
- Merge branch 'master' into dumpRuntimeClassesTest_8341452
- 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21329/files
- new: https://git.openjdk.org/jdk/pull/21329/files/1ab1cbc7..fad43ec3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=00-01
Stats: 14592 lines in 256 files changed: 12478 ins; 1306 del; 808 mod
Patch: https://git.openjdk.org/jdk/pull/21329.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21329/head:pull/21329
PR: https://git.openjdk.org/jdk/pull/21329
More information about the hotspot-dev
mailing list