RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v14]
Simon Tooke
stooke at openjdk.org
Wed Oct 9 07:16:13 UTC 2024
> This PR changes the status of realpath() from a Posix-specific API to a globally available API, i.e. adding it to the "Hotspot Porting API". Code would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires a Windows implementation of realpath(), using Windows _fullpath(), and renaming os::Posix::realpath() to os::realpath().
>
> The main difference between POSIX and Windows behaviour is that POSIX actually requires an existing accessible file, while Windows will happily work with made-up filenames.
>
> Please note that guidelines for doing this appear in src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
feedback from review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/files
- new: https://git.openjdk.org/jdk/pull/20683/files/920f67d8..6715569a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20683&range=13
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20683&range=12-13
Stats: 24 lines in 1 file changed: 5 ins; 1 del; 18 mod
Patch: https://git.openjdk.org/jdk/pull/20683.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20683/head:pull/20683
PR: https://git.openjdk.org/jdk/pull/20683
More information about the hotspot-dev
mailing list