RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing [v3]

Matias Saavedra Silva matsaave at openjdk.org
Thu Oct 10 17:39:44 UTC 2024


> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`. 
> 
> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.

Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:

 - Changed method name and added helper
 - Ioi comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21329/files
  - new: https://git.openjdk.org/jdk/pull/21329/files/fad43ec3..11a5499f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=01-02

  Stats: 44 lines in 7 files changed: 13 ins; 26 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/21329.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21329/head:pull/21329

PR: https://git.openjdk.org/jdk/pull/21329


More information about the hotspot-dev mailing list