RFR: 8318127: align_up has potential overflow [v8]
Kim Barrett
kbarrett at openjdk.org
Thu Oct 10 17:53:13 UTC 2024
On Thu, 10 Oct 2024 15:12:57 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:
>> Hi everyone,
>>
>> The `align_up` function contained code which could potentially overflow and produce an incorrect result. This PR adds an assert to check for such.
>>
>> Additionally, two test case that previously caused an overflow have been updated to use the highest possible values that do not trigger an overflow.
>
> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>
> newline at eof
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20808#pullrequestreview-2361044111
More information about the hotspot-dev
mailing list