RFR: 8341893: AArch64: Micro-optimize compressed ptr decoding

Fei Yang fyang at openjdk.org
Mon Oct 14 07:35:09 UTC 2024


On Thu, 10 Oct 2024 07:57:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug for full description. I think there is an accidental inefficiency in decoding: we don't have to shift when shift is zero, but we are tripped by `d != s` check. Other architectures seem to do this right. This fix surgically fixes the decoding. I have a variant of a more comprehensive MacroAssembler fix that could cover this shift-to-mov translation wholesale, but that fix is riskier.
> 
> Additional testing:
>  - [x] Linux AArch64 server fastdebug, `tier{1,2,3}`

LGTM. Seems riscv bears a similar issue. Will check and propose a seperate fix.

LGTM. Seems riscv bears a similar issue. Will check and propose a seperate fix.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21443#pullrequestreview-2365619704
PR Review: https://git.openjdk.org/jdk/pull/21443#pullrequestreview-2365621037


More information about the hotspot-dev mailing list