RFR: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags

[Hamlin Li]

On Mon, 14 Oct 2024 08:56:46 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/gc/g1/g1_riscv.ad line 169:
>> 
>>> 167:   predicate(UseG1GC && n->as_LoadStore()->barrier_data() != 0);
>>> 168:   match(Set res (CompareAndExchangeP mem (Binary oldval newval)));
>>> 169:   effect(TEMP res, TEMP tmp1, TEMP tmp2);
>> 
>> should the effect of `res` be changed from `TEMP` to `DEF_TEMP`?
>> And other similar usage places.
>
> Ah, that looks like a refactoring change to me. Maybe go with a separate change if it's necessary? Seems not strongly related to this PR.

Yes, make sense to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21485#discussion_r1799081784