RFR: 8340241: RISC-V: Returns mispredicted [v7]

Robbin Ehn rehn at openjdk.org
Mon Oct 14 11:42:31 UTC 2024


On Mon, 14 Oct 2024 10:51:30 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Yes, we can, but in some cases the use of t1 is not obvious therefore I was unsure if I should make t1 default or not.
>> I'll change then.
>
> Sorry I didn't mention that there are some other occurrences like changes made in file src/hotspot/cpu/riscv/stubGenerator_riscv.cpp. I would prefer to use the default param where possible just for consistency with other callsites. As I remembered, it's very rare that `t0` / `t1` is alive at the jump target.

Fixed more

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21406#discussion_r1799333536


More information about the hotspot-dev mailing list