RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Mon Oct 14 14:57:26 UTC 2024
> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`.
>
> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.
Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
Removed unused include
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21329/files
- new: https://git.openjdk.org/jdk/pull/21329/files/eee9df2b..40f07064
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21329&range=03-04
Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/21329.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21329/head:pull/21329
PR: https://git.openjdk.org/jdk/pull/21329
More information about the hotspot-dev
mailing list