RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v2]

[Serguei Spitsyn]

On Tue, 15 Oct 2024 20:54:45 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Overall the fix looks good. I made a couple of minor suggestions for the test. Make sure you test on all platforms and with -Xcomp since the test is timing sensitive.

Thank you for reviewing this! Good suggestion about an extensive testing with -Xcomp.

> src/hotspot/share/prims/jvmtiThreadState.hpp line 364:
> 
>> 362:   void set_top_frame_is_exiting() { _top_frame_is_exiting = true;  }
>> 363:   void clr_top_frame_is_exiting() { _top_frame_is_exiting = false; }
>> 364:   bool is_top_frame_is_exiting()  { return _top_frame_is_exiting;  }
> 
> Just noticed you are using "is" twice in this API. I'm not sure of the hotspot convention here. Seems probably the first "is" should be dropped.

Good catch, thanks. Fixed now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21468#issuecomment-2415360803
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1802139368