RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v5]
Ioi Lam
iklam at openjdk.org
Wed Oct 16 02:42:54 UTC 2024
On Tue, 15 Oct 2024 19:40:15 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
>>
>> - @DanHeidinga comments -- added ConcurrentHashMap::runtimeSetup() to init NCPU to runtime value; also use the same runtimeSetup() pattern to call registerNatives() for Class.java and Unsafe.java
>> - Merge branch 'jep-483-step-06-8311071-avoid-soft-refs-in-java-lang-invoke' into jep-483-step-07-8293336-store-lambda-forms-in-cds-archive
>> - Fixed JDK-8341988: jstack launched with AOT cache created with -XX:+AOTClassLinking crashes
>> - 8341600: [premain] Automatic aot-init of classes used by java.lang.invoke
>> - @adinn comments
>> - improve checks for not changing <clinit> order for aot linking of lambda; added comprehensive test cases: AOTLinkedLambdasApp::testClinitOrder()
>> - Clean up of aotClassInitializer and cdsHeaVerifier; added lambda test cases for <clinit> order of app classes
>> - Merge branch 'jep-483-step-06-8311071-avoid-soft-refs-in-java-lang-invoke' into jep-483-step-07-8293336-store-lambda-forms-in-cds-archive
>> - Require all <clinit> of supertypes of aot-inited classes to be executed in assembly phase
>> - Limit the use of AOTHolder
>> - ... and 19 more: https://git.openjdk.org/jdk/compare/e46b910a...382446d4
>
> src/hotspot/share/oops/cpCache.cpp line 52:
>
>> 50: #include "oops/objArrayOop.inline.hpp"
>> 51: #include "oops/oop.inline.hpp"
>> 52: #include "oops/method.inline.hpp"
>
> Could you go over the entire patch and fix sort order of added includes.
I fixed the include problems found by my script. I'll make sure to run the script again before the final push.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1802252522
More information about the hotspot-dev
mailing list