RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing [v5]

[David Holmes]

On Mon, 14 Oct 2024 14:57:26 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`. 
>> 
>> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused include

One renaming suggestion but otherwise seems fine. Thanks.

src/hotspot/share/cds/cdsProtectionDomain.cpp line 212:

> 210: }
> 211: 
> 212: oop CDSProtectionDomain::get_shared_jar_url_helper(const char* path, Handle url_h, TRAPS) {

Suggestion:

oop CDSProtectionDomain::get_file_URL(const char* path, Handle url_h, TRAPS) {

It looks odd to have a "helper" method as part of the public API, especially when called directly.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21329#pullrequestreview-2371203175
PR Review Comment: https://git.openjdk.org/jdk/pull/21329#discussion_r1802356129