RFR: 8341527: AVX-512 intrinsic for SHA3 [v4]

Tobias Hartmann thartmann at openjdk.org
Wed Oct 16 07:30:13 UTC 2024


On Sat, 5 Oct 2024 16:47:12 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> There is already an intrinsic for SHA-3 for aarch64, which gives significant speed improvement on that architecture, so this pull request is bringing similar improvement for tha x64 family of systems that have the AVX-512 extension. Rudimentary measurements show that 30-40% speed improvement can be achieved.
>
> Ferenc Rakoczi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into sha3-avx512-intrinsic
>  - fix windows build
>  - fix debug build
>  - 8341527: AVX-512 intrinsic for SHA3

src/hotspot/cpu/x86/assembler_x86.cpp line 8581:

> 8579:   assert(vector_len == AVX_128bit ? VM_Version::supports_avx() :
> 8580:         (vector_len == AVX_256bit ? VM_Version::supports_avx2() : VM_Version::supports_evex()), "");
> 8581:   // TODO check what legacy_mode needs to be set to

Drive-by comment: There's a TODO left in here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21352#discussion_r1802507743


More information about the hotspot-dev mailing list