RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v20]

[Simon Tooke]

On Wed, 16 Oct 2024 00:03:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clean up test code
>
> Hi @stooke , I was away on vacation when you made the updates.
> 
> I'm afraid I still have some issues about expected behaviour on Windows with regard to the tests.

@dholmes-ora thank you for your comments.  I have updated the comments (and reformatted comments and #ifdef code to match the rest of the tests source.

> test/hotspot/gtest/runtime/test_os.cpp line 425:
> 
>> 423:   EXPECT_TRUE(returnedBuffer == nullptr);
>> 424: #if defined(_WINDOWS)
>> 425:   EXPECT_TRUE(errno == ENAMETOOLONG);
> 
> Why is this the case? Our implementation does not set it and `_fullpath` makes no mention of it.

This is Windows behaviour - Windows 10 with VS 2022 at least.  The existence of a file is not checked, but that non-existent filename better fit into the given buffer!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20683#issuecomment-2416757362
PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1803043747