RFR: 8341527: AVX-512 intrinsic for SHA3 [v4]

[Ferenc Rakoczi]

On Wed, 16 Oct 2024 07:27:02 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into sha3-avx512-intrinsic
>>  - fix windows build
>>  - fix debug build
>>  - 8341527: AVX-512 intrinsic for SHA3
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 8581:
> 
>> 8579:   assert(vector_len == AVX_128bit ? VM_Version::supports_avx() :
>> 8580:         (vector_len == AVX_256bit ? VM_Version::supports_avx2() : VM_Version::supports_evex()), "");
>> 8581:   // TODO check what legacy_mode needs to be set to
> 
> Drive-by comment: There's a TODO left in here.

Actually, I was hoping that I would learn that from a reviewer @vpaprotsk or @vnkozlov , do you know? I was not able to figure it out from the manual what it should be. (with the current setting "false" at least my code works on the test machines that I tried, but I never tried with "true")

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21352#discussion_r1803352201