RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Oct 17 00:49:23 UTC 2024


On Wed, 16 Oct 2024 21:36:02 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: resolved comments from Alex and Chris
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 99:
> 
>> 97:   res = jvm->GetEnv((void **) &jvmti, JVMTI_VERSION_9);
>> 98:   if (res != JNI_OK || jvmti == nullptr) {
>> 99:     LOG("GetEnv(JVMTI_VERSION_9) failedL error(%d)", res);
> 
> Suggestion:
> 
>     LOG("GetEnv(JVMTI_VERSION_9) failed: error(%d)", res);

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1803965649


More information about the hotspot-dev mailing list