RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v22]
David Holmes
dholmes at openjdk.org
Thu Oct 17 00:51:25 UTC 2024
On Wed, 16 Oct 2024 13:17:48 GMT, Simon Tooke <stooke at openjdk.org> wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a globally available API, i.e. adding it to the "Hotspot Porting API". Code would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires a Windows implementation of realpath(), using Windows _fullpath(), and renaming os::Posix::realpath() to os::realpath().
>>
>> The main difference between POSIX and Windows behaviour is that POSIX actually requires an existing accessible file, while Windows will happily work with made-up filenames.
>>
>> Please note that guidelines for doing this appear in src/hotspot/share/runtime/os.hpp
>
> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>
> clean up whitespace error
Marked as reviewed by dholmes (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/20683#pullrequestreview-2373927879
More information about the hotspot-dev
mailing list