Integrated: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows
Simon Tooke
stooke at openjdk.org
Thu Oct 17 08:09:25 UTC 2024
On Thu, 22 Aug 2024 18:36:39 GMT, Simon Tooke <stooke at openjdk.org> wrote:
> This PR changes the status of realpath() from a Posix-specific API to a globally available API, i.e. adding it to the "Hotspot Porting API". Code would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires a Windows implementation of realpath(), using Windows _fullpath(), and renaming os::Posix::realpath() to os::realpath().
>
> The main difference between POSIX and Windows behaviour is that POSIX actually requires an existing accessible file, while Windows will happily work with made-up filenames.
>
> Please note that guidelines for doing this appear in src/hotspot/share/runtime/os.hpp
This pull request has now been integrated.
Changeset: 7a64fbbb
Author: Simon Tooke <stooke at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/7a64fbbb9292f4d65a6970206dec1a7d7645046b
Stats: 133 lines in 11 files changed: 109 ins; 10 del; 14 mod
8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows
Reviewed-by: dholmes, stuefe, jwaters
-------------
PR: https://git.openjdk.org/jdk/pull/20683
More information about the hotspot-dev
mailing list