Integrated: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing
Matias Saavedra Silva
matsaave at openjdk.org
Thu Oct 17 13:59:16 UTC 2024
On Thu, 3 Oct 2024 17:43:50 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
> DumpRuntimeClassesTest.java was added in [JDK-8324259](https://bugs.openjdk.org/browse/JDK-8324259) to verify that the newly added dummy call archived classes that are used at CDS runtime. This new test exposed a case where `JarVerifier` is used at CDS runtime while not being in the archive, so this patch performs a dummy call to `JarVerifier`.
>
> When using `-Xcomp`, the class `Manifest` is compiled which causes `JarVerifier` to be loaded. This does not occur in other modes since the constructor of `Manifest` doesn't create any instances of `JarVerifier`. The existing dummy call to `Manifest` doesn't load `JarVerifier` either, so a separate dummy call can be used to ensure it is loaded at dumptime. Now that there are multiple dummy calls, they are pulled out into a new method `make_dummy_calls()`. Verified with tier x-y tests.
This pull request has now been integrated.
Changeset: 363327e6
Author: Matias Saavedra Silva <matsaave at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/363327e68644b710b0fd549e088beb5c8838a973
Stats: 50 lines in 6 files changed: 25 ins; 20 del; 5 mod
8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing
Reviewed-by: dholmes, iklam
-------------
PR: https://git.openjdk.org/jdk/pull/21329
More information about the hotspot-dev
mailing list