RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v5]

[Serguei Spitsyn]

On Thu, 17 Oct 2024 20:08:44 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review test tweaks: add @bug tag; a reliability update
>
> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 62:
> 
>> 60:          jmethodID method, jboolean wasPoppedByException) {
>> 61:   jvmtiError err;
>> 62:   char* expected_method = (char*)last_notify_method;
> 
> I don't think caching `last_notify_method` adds any reliability.
> `notifyFramePop` deallocates the memory.

Agreed, thanks. Please, see my comment below.

> test/hotspot/jtreg/serviceability/jvmti/events/NotifyFramePopStressTest/libNotifyFramePopStressTest.cpp line 87:
> 
>> 85:   }
>> 86:   deallocate(jvmti, jni, csig);
>> 87:   deallocate(jvmti, jni, name);
> 
> on error `csig` and `name` are deallocated twice

Agreed, thanks. Removed the deallocation on error.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805537772
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805538666