RFR: 8340796: Use a consistent order when loading cxq and EntryList

Dean Long dlong at openjdk.org
Sat Oct 19 01:05:12 UTC 2024


On Fri, 18 Oct 2024 14:44:52 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

> Made sure we use a consistent order when reading ObjectMonitor EntryList and cxq while exiting the monitor.
> That consistent order is EntryList before cxq. Added a comment in the shared code to explaining why it's okay that waiters slip undetected between reading EntryList and cxq.
> 
> Tested ok tier1-3.

We don't have a LoadLoad on aarch64 to enforce the ordering, so isn't it more correct to say that the code handles either ordering correctly, and leave x86 the way it was?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21584#issuecomment-2423418940


More information about the hotspot-dev mailing list