RFR: 8340241: RISC-V: Returns mispredicted [v18]
Fei Yang
fyang at openjdk.org
Mon Oct 21 07:30:45 UTC 2024
On Thu, 17 Oct 2024 14:06:13 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated UEP pretty print with t1
>
> Thanks for the update. Hopefully, I think I can finish first round of review tomorrow. BTW: It will be good to know how this may affect other benchmark workloads, like specjbb2015, etc.
> @RealFYang I programmically looked for t1 uses in Nodes. The only ones I found missing **cr** (set or kill) was ForwardExceptionjmp and RethrowException. But compiler don't expect **cr** to survival these i.e. x86 do not kill **cr** in those cases. Note, maybe some Node(s) was never created, so this is not 100% complete check, but 99%.
Hi, thanks for doing the check. Yeah, I think we should be safe to go.
(And I also created PR fixing similar issue for riscv-specific changes in the loom repo: https://github.com/openjdk/loom/pull/215)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21406#issuecomment-2425836642
More information about the hotspot-dev
mailing list