RFR: 8331341: secondary_super_cache does not scale well: C1 and interpreter [v29]
Andrew Haley
aph at openjdk.org
Mon Oct 21 12:40:01 UTC 2024
On Mon, 21 Oct 2024 11:44:40 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Strengthen assertion
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1819:
>
>> 1817: // This next instruction is equivalent to:
>> 1818: // mov(tmp_reg, (u1)(Klass::SECONDARY_SUPERS_TABLE_SIZE - 1));
>> 1819: // sub(temp2, r_array_index, tmp_reg);
>
> One minor question about the code comment. Should this line be: `// sub(temp2, tmp_reg, slot);`?
Yes, it is. Good spot.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19989#discussion_r1808714248
More information about the hotspot-dev
mailing list