RFR: 8342769: gcc port broken on HotSpot

[David Holmes]

On Tue, 22 Oct 2024 01:17:01 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight withing SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely

The sharedRuntime stuff is tricky and messy. Not sure about what is best/right/workable there. Maybe we even need to factor out like ./os/windows/sharedRuntimeRem.cpp?

src/hotspot/cpu/x86/sharedRuntime_x86.cpp line 102:

> 100: const julong double_sign_mask = CONST64(0x7FFFFFFFFFFFFFFF);
> 101: const julong double_infinity  = CONST64(0x7FF0000000000000);
> 102: #endif

Isn't all this better suited for sharedRuntime_x86_64.cpp?

src/hotspot/os/windows/memMapPrinter_windows.cpp line 178:

> 176:     st->print("%s-%s", mapping_info._state_buffer.base(), mapping_info._type_buffer.base());
> 177:     INDENT_BY(63);
> 178:     st->print("%#11llx", reinterpret_cast<unsigned long long>(mem_info.BaseAddress) - reinterpret_cast<unsigned long long>(mem_info.AllocationBase));

What is the issue with const here?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21627#pullrequestreview-2383602156
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1809742941
PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1809742617