RFR: 8342769: gcc port broken on HotSpot

[David Holmes]

On Tue, 22 Oct 2024 03:45:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/cpu/x86/sharedRuntime_x86.cpp line 102:
>> 
>>> 100: const julong double_sign_mask = CONST64(0x7FFFFFFFFFFFFFFF);
>>> 101: const julong double_infinity  = CONST64(0x7FF0000000000000);
>>> 102: #endif
>> 
>> Isn't all this better suited for sharedRuntime_x86_64.cpp?
>
> You mean the entire custom frem and drem implementation unique to x64 Windows, or just this block of constants here? These constants are used by the custom Windows implementation, so they have to be in the same file. Moving the entire definition for Windows x64 to sharedRuntime_x86_64.cpp seems to be duplicating code even more, and I still don't know whether this is the right solution. It may be that this custom implementation may not be needed anymore and should be removed, which is why I left it in the sharedRuntime_x86.cpp file for the time being

I did mean the entire thing. I don't see any point in WIN64 code being in the x86 file when there is an x86_64 file. Of course I had forgotten about the Aarch64 Windows side, so maybe as I said this is really something for a os/windows file rather then `cpu/<arch>` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1810380132