RFR: 8342768: GTest AssemblerX86.validate_vm failed: assert(VM_Version::supports_bmi1()) failed: tzcnt instruction not supported [v2]

[Sandhya Viswanathan]

On Tue, 22 Oct 2024 18:11:45 GMT, hanklo6 <duke at openjdk.org> wrote:

>> The `tzcnt` instruction requires the VM to support `bmi1` feature, which we set directly when running the test.
>
> hanklo6 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   set avx and evex in test

src/hotspot/cpu/x86/vm_version_x86.hpp line 646:

> 644:   static void set_evex_cpuFeatures() { _features |= (CPU_AVX512F | CPU_SSE | CPU_SSE2 | CPU_VZEROUPPER ); }
> 645:   static void set_apx_cpuFeatures() { _features |= CPU_APX_F; }
> 646:   static void set_bmi1_cpuFeatures() { _features |= CPU_BMI1; }

It would be better to change this as:
static void set_bmi_cpuFeatures() { _features |= (CPU_BMI1 | CPU_BMI2 | CPU_LZCNT); }
And then use set_bmi_cpuFeatures() in the gtest.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21644#discussion_r1811590174