RFR: 8342768: GTest AssemblerX86.validate_vm failed: assert(VM_Version::supports_bmi1()) failed: tzcnt instruction not supported [v2]

[hanklo6]

On Wed, 23 Oct 2024 00:19:26 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> hanklo6 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   set avx and evex in test
>
> src/hotspot/cpu/x86/vm_version_x86.hpp line 646:
> 
>> 644:   static void set_evex_cpuFeatures() { _features |= (CPU_AVX512F | CPU_SSE | CPU_SSE2 | CPU_VZEROUPPER ); }
>> 645:   static void set_apx_cpuFeatures() { _features |= CPU_APX_F; }
>> 646:   static void set_bmi1_cpuFeatures() { _features |= CPU_BMI1; }
> 
> It would be better to change this as:
> static void set_bmi_cpuFeatures() { _features |= (CPU_BMI1 | CPU_BMI2 | CPU_LZCNT); }
> And then use set_bmi_cpuFeatures() in the gtest.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21644#discussion_r1813940235