RFR: 8327156: Avoid copying in StringTable::intern(oop, TRAPS) [v3]

David Holmes dholmes at openjdk.org
Thu Oct 24 01:46:12 UTC 2024


On Wed, 23 Oct 2024 13:59:16 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> test/hotspot/gtest/classfile/test_stringConversion.cpp line 36:
>> 
>>> 34: 
>>> 35: // Complex string " Jāvá®!☺☻ ", UTF8 has character lengths 13122133 = 16
>>> 36: static const unsigned char static_utf8_str[] = {0x4A, 0x61, 0xCC, 0x84, 0x76, 0xC3, 0xA1, 0xC2, 0xAE, 0x21, 0xE2, 0x98, 0xBA, 0xE2, 0x98, 0xBB};
>> 
>> 0x61 is `a` not a-with-tilde ??
>
> 'ā' in this case is an 'a' (0x61) followed by a [Combining Macron](https://www.compart.com/en/unicode/U+0304) '◌̄' (0xCC 0x84)

Oh that is subtle.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21325#discussion_r1814116942


More information about the hotspot-dev mailing list