RFR: 8340796: Use a consistent order when loading cxq and EntryList [v2]

Fredrik Bredberg fbredberg at openjdk.org
Thu Oct 24 15:50:06 UTC 2024


On Mon, 21 Oct 2024 23:48:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after review
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 480:
> 
>> 478:   membar(StoreLoad);
>> 479: 
>> 480:   // Check if the entry lists are empty.
> 
> Suggestion:
> 
>   // Check if the entry lists are empty (EntryList first - by convention).

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21584#discussion_r1815271380


More information about the hotspot-dev mailing list