RFR: 8342768: GTest AssemblerX86.validate_vm failed: assert(VM_Version::supports_bmi1()) failed: tzcnt instruction not supported [v3]

[hanklo6]

On Thu, 24 Oct 2024 15:22:52 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/cpu/x86/vm_version_x86.hpp line 646:
>> 
>>> 644:   static void set_evex_cpuFeatures() { _features |= (CPU_AVX512F | CPU_SSE | CPU_SSE2 | CPU_VZEROUPPER ); }
>>> 645:   static void set_apx_cpuFeatures() { _features |= CPU_APX_F; }
>>> 646:   static void set_bmi_cpuFeatures() { _features |= (CPU_BMI1 | CPU_BMI2 | CPU_LZCNT); }
>> 
>> __ popcntl(rbx, r8);                                                        //    {load}popcnt ebx, r8d    IID137
>>     __ popcntl(r8, r9);                                                         //    {load}popcnt r8d, r9d    IID138
>>     __ popcntl(r9, r10);                                                        //    {load}popcnt r9d, r10d    IID139
>> 
>> Please also add feature CPU_POPCNT
>
> I suggest to do that in separate PR since we already tested current version.

Thanks, I'll add it on another PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21644#discussion_r1815297592