RFR: 8340796: Use a consistent order when loading cxq and EntryList [v2]
David Holmes
dholmes at openjdk.org
Fri Oct 25 00:01:10 UTC 2024
On Thu, 24 Oct 2024 15:28:37 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> Made sure we use a consistent order when reading ObjectMonitor EntryList and cxq while exiting the monitor.
>> That consistent order is EntryList before cxq. Added a comment in the shared code to explaining why it's okay that waiters slip undetected between reading EntryList and cxq.
>>
>> Tested ok tier1-3.
>
> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>
> Update after review
LGTM!
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21584#pullrequestreview-2393898957
More information about the hotspot-dev
mailing list