RFR: 8341527: AVX-512 intrinsic for SHA3 [v8]

Volodymyr Paprotski duke at openjdk.org
Mon Oct 28 16:56:31 UTC 2024


On Fri, 25 Oct 2024 14:16:40 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> There is already an intrinsic for SHA-3 for aarch64, which gives significant speed improvement on that architecture, so this pull request is bringing similar improvement for tha x64 family of systems that have the AVX-512 extension. Rudimentary measurements show that 30-40% speed improvement can be achieved.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added comments

Thanks for the comments. Still looks good to me 

(I haven't reviewed the core loop instruction-by-instruction either, I would need to spend a lot more time getting to know SHA3. But this is why I was asking about KAT/testing; This is 'condition-less' code,  and no additions/carries-to-propagate. Testing _should_ have 100% code-coverage with just a few tests., so no need to tests carries, input text value-independent. Do need to vary input length to test loop bounds).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21352#issuecomment-2442122971


More information about the hotspot-dev mailing list