RFR: 8342818: Implement CPU Time Profiling for JFR
Johannes Bechberger
jbechberger at openjdk.org
Tue Oct 29 11:00:25 UTC 2024
On Tue, 1 Oct 2024 22:43:11 GMT, Andrei Pangin <apangin at openjdk.org> wrote:
>> This is the code for the [JEP draft: CPU Time based profiling for JFR].
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 457:
>
>> 455: int64_t new_value = 0;
>> 456: if (throttle < 0) { // off
>> 457: new_value = period_millis;
>
> Here `new_value` can be set to `-1` thus causing an invalid interval passed to `timer_settime` later.
Good catch, fixed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1784308182
More information about the hotspot-dev
mailing list