RFR: 8342818: Implement CPU Time Profiling for JFR

[Johannes Bechberger]

On Thu, 17 Oct 2024 10:44:25 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.inline.hpp line 92:
>> 
>>> 90:   auto holder = method->method_holder();
>>> 91:   auto res = load(holder, method);
>>> 92:   return res;
>> 
>> Why this change?
>
> Good catch, I'll remove it

I'll be cleaning up the changes tomorrow, I found two more.

>> src/hotspot/share/jfr/recorder/stacktrace/jfrAsyncStackTrace.cpp line 126:
>> 
>>> 124:   for (u4 i = 0; i < _nr_of_frames; i++) {
>>> 125:     const JfrAsyncStackFrame& frame = _frames[i];
>>> 126:     if (!Method::is_valid_method(frame._method) || is_full(enqueue_buffer)) {
>> 
>> We should try to remove is_full(enqueue_buffer)).
>
> This code is similar to the code in the old sampler and ensures that the buffer is large enough.

I removed the code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1804541399
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1756647218