RFR: 8342818: Implement CPU Time Profiling for JFR

Erik Gahlin egahlin at openjdk.org
Tue Oct 29 13:40:14 UTC 2024


On Wed, 28 Aug 2024 16:47:21 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

> This is the code for the [JEP draft: CPU Time based profiling for JFR].

test/jdk/jdk/jfr/event/metadata/TestLookForUntestedEvents.java line 92:

> 90:     // Experimental events
> 91:     private static final Set<String> experimentalEvents = Set.of(
> 92:         "Flush", "SyncOnValueBasedClass", "CPUTimeSample", "CPUTimeSampleLoss");

I think the reason we added an exclusion list for experimental events is so developers wouldn't be forced to write a test. Since you have a test for CPUTimeSample event, I think you can remove it.

(If TestLookForUntestedEvents is not able to find the event test, write the event name in the test)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1820812002


More information about the hotspot-dev mailing list