RFR: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics [v10]
Arseny Bochkarev
duke at openjdk.org
Wed Oct 30 14:23:42 UTC 2024
On Tue, 29 Oct 2024 12:13:55 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> I'm not very familiar with OpenSSL but I guess it is just uses different endianness when storing the result :shrug: (compared to [big-endian](https://docs.oracle.com/javase/specs/jvms/se23/html/jvms-2.html#jvms-2.11) JVM). I'll left the note on it in the code
>
> Hmm ... I didn't find a direct evidence about the endianness of the key required here. Was is documented anywhere? I prefer to add some more details in the code comment to make it more readable.
All I was able to find is [this](https://stackoverflow.com/a/9455607) answer :shrug: Well if it is fully big-endian and in our case we store keys little-endian (as stated in the comment [here](https://github.com/openjdk/jdk/pull/19960/files#diff-97f199af6d1c8c17b2fa4f50eb1bbc0081858cc59a899f32792a2d31f933ccc4R2304)) then the difference in keys loading is expected (but again, it is just the guess 😕). I'll expand the comment, no problem!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19960#discussion_r1822742476
More information about the hotspot-dev
mailing list