RFR: 8342818: Implement CPU Time Profiling for JFR [v4]
Markus Grönlund
mgronlun at openjdk.org
Wed Oct 30 21:51:42 UTC 2024
On Wed, 30 Oct 2024 18:16:25 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:
>> src/jdk.jfr/share/conf/jfr/profile.jfc line 195:
>>
>>> 193: <event name="jdk.CPUTimeSample">
>>> 194: <setting name="enabled" control="method-sampling-enabled">false</setting>
>>> 195: <setting name="throttle">10ms</setting>
>>
>> Can a rate be given here instead of an absolute value? Otherwise, there is a mismatch between the default. jfc and the profile.jfc which seems quite unintuitive.
>
> I wanted to give the user the info that both formats are usable (because this is documented nowhere else) and in profiling we usually don't care about having too many events.
We do care about having too many events, even for profiling.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823436294
More information about the hotspot-dev
mailing list