RFR: 8342818: Implement CPU Time Profiling for JFR [v4]

David Holmes dholmes at openjdk.org
Thu Oct 31 02:59:35 UTC 2024


On Wed, 30 Oct 2024 07:32:23 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 78:
>> 
>>> 76: }
>>> 77: 
>>> 78: static bool thread_state_in_native(JavaThread* thread) {
>> 
>> Whatever this is checking it is not what we normally call "in native" so please come up with a different name.
>
> This is the same name the other sampler uses.

Ugghh!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823713147


More information about the hotspot-dev mailing list